Repository navigation
Conversation
url/1,2,3 passed the original ~p route to static_url/2 for static paths, skipping the percent-encoding of interpolated values that ~p paths and non-static urls get. Pass the rewritten route instead. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6909
For paths under a configured
:staticsprefix,url/1,2,3passed the original~proute tostatic_url/2, so interpolated values were not percent-encoded, unlike~ppaths and non-static urls.rewrite_path/4now also builds astatic_urlAST from the rewritten (encoded) route, mirroring the existing static path handling.Test plan
verified_routes_test.exschecks that~p,path/2,url/1andurl/2all encodea/b?x=1#the same way under a static prefix. It fails before the change and passes after.mix test test/phoenix/verified_routes_test.exs test/phoenix/routerpasses; changed files are formatted.AI disclosure: this change was prepared with AI assistance (Claude Code) and reviewed before submission.